Support git init and clone in wasm tests #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianthomas23
commented
Jan 30, 2026
|
|
||
| assert os.path.exists(os.path.join(tmp_path, "xtl")) | ||
| assert os.path.exists(os.path.join(tmp_path, "xtl/include")) | ||
| assert (tmp_path / "xtl").exists() |
Member
Author
There was a problem hiding this comment.
I've switched from os.path functions to pathlib.Path as the latter are mocked correctly for wasm and I don't want to also mock os.path too.
ianthomas23
commented
Jan 30, 2026
| p_status = subprocess.run(status_cmd, capture_output=True, cwd=tmp_path / "xtl", text=True) | ||
| if not GIT2CPP_TEST_WASM: | ||
| # TODO: fix this in wasm build | ||
| assert p_status.returncode != 0 |
Member
Author
There was a problem hiding this comment.
I've added to this test as it was behaving strangely, and it turns out the error code here is wrong in wasm but correct in linux/macos. I've no idea yet about how this could possibly occur!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends to wasm tests to include
git init(lots of filesystem access) andgit clone(https requests from github via a CORS proxy). The tests covered now aretest_clone.py,test_git.py,test_init.pyand the newtest_fixtures.pywhich tests the new fixtures and mocks that are defined inconftest_wasm.pyto run test code in the browser rather than in python on the local file system.By default such testing now uses the latest
mainbranch ofcocklerather than the latest release. There are two newcmakeoptions:USE_RECIPE_PATCHES: Use patches from emscripten-forge recipe or not, default isONUSE_COCKLE_RELEASE: Use latest cockle release rather than repo main branch, default isOFFThe testing framework now serves it own CORS proxy using cors-anywhere to avoid using a free public CORS proxy which can be rate limited or otherwise restricted or unreliable.
This is now using emscripten 4.x builds. All the important information on how to use this is in the
wasm/README.mdfile and it should be easily runable on any linux or macos system.Future work in separate PRs:
test_*.pyfiles. Some of this will hopefully be quite easy, some not.