Fix max charge override being set during charge pre-pass #9442
+29
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After PathOfBuildingCommunity#7186 doActorCharges is ran early to supply charge data to other logic in CalcPerform.lua PathOfBuildingCommunity#7328 added an extra override to improve max charge count display causing the pre pass to set the override which is then not overwritten during the main charge calculation pass. This means that conditional maximum charge mods such as "+1 to Maximum Frenzy Charges while affected by Grace" which rely on conditions set after the charge pre-pass were not accounted for in the main pass. This pr simply uses the ReplaceMod function to replace the max charges override mod during the last/main pass. Signed-off-by: Paliak <91493239+Paliak@users.noreply.github.com>
Signed-off-by: Paliak <91493239+Paliak@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9431
Description of the problem being solved:
After #7186 doActorCharges is ran early to supply charge data to other logic in CalcPerform.lua #7328 added an extra override to improve max charge count display causing the pre-pass to set the override which is then not overwritten during the main charge calculation pass. This means that conditional maximum charge mods such as "+1 to Maximum Frenzy Charges while affected by Grace" which rely on conditions set after the charge pre-pass were not accounted for in the main pass. This pr simply uses the ReplaceMod function to replace the max charges override mod during the last/main pass.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
See issue