Skip to content

Conversation

@koji
Copy link
Contributor

@koji koji commented Jan 28, 2026

Overview

fix remove well view from spotlight window

[before]
Screenshot 2026-01-28 at 6 09 12 PM

[after]
https://github.com/user-attachments/assets/68b57506-cc14-4456-8b30-2dcbb73b57e0

close AUTH-2721

Test Plan and Hands on Testing

  • run the protocol that is attached to the ticket

Changelog

  • remove wellview from the component in spotlight window

Review requests

Risk assessment

low

fix remove well view from spotlight window

close AUTH-2721
@koji koji requested review from jerader and ncdiehl11 January 28, 2026 23:28
@koji koji marked this pull request as ready for review January 28, 2026 23:32
@codecov
Copy link

codecov bot commented Jan 28, 2026

Codecov Report

❌ Patch coverage is 47.36842% with 60 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.66%. Comparing base (0917704) to head (c7e3436).

Files with missing lines Patch % Lines
...olVisualization/SecondWindow/LabwareSlot/index.tsx 48.21% 58 Missing ⚠️
...esktop/ProtocolVisualization/SlotDetails/index.tsx 0.00% 1 Missing ⚠️
app/src/pages/Desktop/StepDetailViewer/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-9.0.0   #20731      +/-   ##
=======================================================
- Coverage                56.76%   56.66%   -0.10%     
=======================================================
  Files                     3914     3914              
  Lines                   322916   322877      -39     
  Branches                 45745    45737       -8     
=======================================================
- Hits                    183289   182964     -325     
- Misses                  139410   139698     +288     
+ Partials                   217      215       -2     
Flag Coverage Δ
app 45.89% <47.36%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...esktop/ProtocolVisualization/SlotDetails/index.tsx 2.27% <0.00%> (+0.09%) ⬆️
app/src/pages/Desktop/StepDetailViewer/index.tsx 2.94% <0.00%> (+0.08%) ⬆️
...olVisualization/SecondWindow/LabwareSlot/index.tsx 61.39% <48.21%> (-3.53%) ⬇️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants