Skip to content

Conversation

@koji
Copy link
Contributor

@koji koji commented Jan 27, 2026

Overview

fix undefined nozzle access

visualization_test.mov

close RQA-5098

Test Plan and Hands on Testing

  • import the protocol that is attached to the ticket
  • select the protocol and click visualize button
  • click play button

Changelog

  • change channel based condition check to nozzle based condition check

Review requests

Risk assessment

low

fix undefined nozzle access

close RQA-5098
@koji koji requested review from jerader and ncdiehl11 January 27, 2026 23:06
`forDropTip expected ${labwareId} to have definition and to be a tiprack`
)

// TODO (nd 08/12/2025): handle tip (re)placement more elegantly depending on pipette specs and selected nozzles
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this change is acceptable, probably we can remove this comment.

@koji koji marked this pull request as ready for review January 27, 2026 23:08
@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

❌ Patch coverage is 32.67327% with 68 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.69%. Comparing base (8d79c18) to head (9006b2e).
⚠️ Report is 2 commits behind head on chore_release-9.0.0.

Files with missing lines Patch % Lines
...n/src/getNextRobotStateAndWarnings/forPickUpTip.ts 21.73% 36 Missing ⚠️
...ion/src/getNextRobotStateAndWarnings/forDropTip.ts 23.80% 32 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-9.0.0   #20715      +/-   ##
=======================================================
- Coverage                56.70%   56.69%   -0.01%     
=======================================================
  Files                     3914     3915       +1     
  Lines                   323184   323262      +78     
  Branches                 45771    45772       +1     
=======================================================
+ Hits                    183268   183286      +18     
- Misses                  139699   139759      +60     
  Partials                   217      217              
Flag Coverage Δ
protocol-designer 19.61% <25.74%> (+<0.01%) ⬆️
step-generation 5.72% <32.67%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...tRobotStateAndWarnings/forConfigureNozzleLayout.ts 100.00% <ø> (ø)
...neration/src/getNextRobotStateAndWarnings/index.ts 63.74% <100.00%> (-0.35%) ⬇️
step-generation/src/utils/getNozzleConfig.ts 100.00% <100.00%> (ø)
step-generation/src/utils/index.ts 75.00% <ø> (ø)
...ion/src/getNextRobotStateAndWarnings/forDropTip.ts 45.56% <23.80%> (-18.27%) ⬇️
...n/src/getNextRobotStateAndWarnings/forPickUpTip.ts 44.87% <21.73%> (-23.32%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants