-
Notifications
You must be signed in to change notification settings - Fork 192
feat(abr-testing): add thermocycler ramp rates #20655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: edge
Are you sure you want to change the base?
Conversation
abr-testing/abr_testing/protocols/active_protocols/11_IDT xGen 1000 ul 96ch.py
Outdated
Show resolved
Hide resolved
abr-testing/abr_testing/protocols/active_protocols/12_Illumina RNA all parts.py
Outdated
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## edge #20655 +/- ##
=======================================
Coverage 56.72% 56.72%
=======================================
Files 3912 3912
Lines 323089 323089
Branches 45759 45759
=======================================
Hits 183278 183278
Misses 139593 139593
Partials 218 218
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
… 1000 ul 96ch.py Co-authored-by: Rhyann Clarke <146747548+rclarke0@users.noreply.github.com>
… RNA all parts.py Co-authored-by: Rhyann Clarke <146747548+rclarke0@users.noreply.github.com>
rclarke0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Each of these files has a command to comment the version of the protocol :
helpers.comment_protocol_version(protocol, "03")
For each file, increase the version number by 1 to indicate that the files have changed
Also change the commit title to feat(abr-testing): add custom thermocycler ramp rates
After that you can test these protocols on the ABR robots to ensure.
Lastly, I think we should wait to merge these until we can physically test them on the robot.
Overview
Updated relevant ABR protocols to include thermocycler ramp rates
Test Plan and Hands on Testing
Tested using make simulate, caught ramp_rate simulate bug.
Changelog
Modified all files in abr-testing/abr_testing/protocols/active_protocols that used the Thermocycler Context. Updated based on the following three rules:
Risk assessment
Low risk, isolated to the ABR testing suite. Effects end at the end of each affected script.