Skip to content

Conversation

@munanwugo-opentrons
Copy link
Contributor

@munanwugo-opentrons munanwugo-opentrons commented Jan 21, 2026

Overview

Updated relevant ABR protocols to include thermocycler ramp rates

Test Plan and Hands on Testing

Tested using make simulate, caught ramp_rate simulate bug.

Changelog

Modified all files in abr-testing/abr_testing/protocols/active_protocols that used the Thermocycler Context. Updated based on the following three rules:

  1. Don't update from Room temperature (broken for purposes of testing in 2_BMS_PCR_Protocol)
  2. Max out theoretical ramp rate (4 heating, 2 cooling)
  3. Do not change ramp rate when prior temperature is the same as current

Risk assessment

Low risk, isolated to the ABR testing suite. Effects end at the end of each affected script.

@munanwugo-opentrons munanwugo-opentrons marked this pull request as ready for review January 21, 2026 21:48
@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.72%. Comparing base (d8b9a24) to head (0674d5d).
⚠️ Report is 1 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #20655   +/-   ##
=======================================
  Coverage   56.72%   56.72%           
=======================================
  Files        3912     3912           
  Lines      323089   323089           
  Branches    45759    45759           
=======================================
  Hits       183278   183278           
  Misses     139593   139593           
  Partials      218      218           
Flag Coverage Δ
app 46.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

munanwugo-opentrons and others added 3 commits January 22, 2026 09:25
… 1000 ul 96ch.py

Co-authored-by: Rhyann Clarke <146747548+rclarke0@users.noreply.github.com>
… RNA all parts.py

Co-authored-by: Rhyann Clarke <146747548+rclarke0@users.noreply.github.com>
Copy link
Contributor

@rclarke0 rclarke0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each of these files has a command to comment the version of the protocol :

helpers.comment_protocol_version(protocol, "03")

For each file, increase the version number by 1 to indicate that the files have changed

Also change the commit title to feat(abr-testing): add custom thermocycler ramp rates
After that you can test these protocols on the ABR robots to ensure.

Lastly, I think we should wait to merge these until we can physically test them on the robot.

@munanwugo-opentrons munanwugo-opentrons changed the title Thermocycler ramp rates feat(abr-testing): add thermocycler ramp rates Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants