Skip to content

Conversation

@y3rsh
Copy link
Member

@y3rsh y3rsh commented Jan 16, 2026

Overview

Add Applitools eyes capability to the end to end test framework and demonstrate how to use it.

  • fix status code not being exposed for pytest run and silently passing in CI
  • add test id for the timeline
  • add timeline page object with locator and scrolling
  • eyes fixture
  • eyes batch id set on pytest startup so batches are a group of tests
  • added 3 checks so that we had to figure out
    • multiple tests in a run with checks
    • element vs page checks
    • scrolling (.fully() on scrollable element)
    • multiple checks in one test
image

@y3rsh y3rsh self-assigned this Jan 16, 2026
@alexjoel42
Copy link
Contributor

alexjoel42 commented Jan 17, 2026

alexjoel42 added a commit that referenced this pull request Jan 17, 2026
add more intuitive troubleshooting steps for running local tests and make troubleshoot to show where
failed tests  break

#20630
Copy link
Contributor

@skowalski08 skowalski08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@y3rsh
Copy link
Member Author

y3rsh commented Jan 22, 2026

We might want stitching instead of fully for the window itself to scroll down

I messed around with this and I think that we would need to create a new function to target a specific element that is scrollable to use the functions. The details modal is very hard to locate and so if we decide we want this in the future then we will need to add a testid I think.

@y3rsh y3rsh requested review from a team as code owners January 27, 2026 16:40
@y3rsh y3rsh requested review from TamarZanzouri and removed request for a team January 27, 2026 16:40
@y3rsh y3rsh changed the base branch from chore_release-pd-8.8.0 to edge January 27, 2026 16:40
@codecov
Copy link

codecov bot commented Jan 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.54%. Comparing base (964eec3) to head (d17ea0e).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #20630   +/-   ##
=======================================
  Coverage   56.54%   56.54%           
=======================================
  Files        3916     3916           
  Lines      323256   323259    +3     
  Branches    45766    45766           
=======================================
+ Hits       182773   182776    +3     
  Misses     140267   140267           
  Partials      216      216           
Flag Coverage Δ
app 45.95% <0.00%> (-0.01%) ⬇️
protocol-designer 19.67% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
components/src/organisms/Toolbox/index.tsx 97.19% <100.00%> (+0.05%) ⬆️
...esigner/ProtocolSteps/Timeline/TimelineToolbox.tsx 83.07% <100.00%> (+0.13%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@alexjoel42 alexjoel42 self-requested a review January 27, 2026 19:39
@y3rsh y3rsh requested a review from skowalski08 January 27, 2026 22:10
@y3rsh
Copy link
Member Author

y3rsh commented Jan 27, 2026

We might want stitching instead of fully for the window itself to scroll down

I messed around with this and I think that we would need to create a new function to target a specific element that is scrollable to use the functions. The details modal is very hard to locate and so if we decide we want this in the future then we will need to add a testid I think.

Did this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants