Skip to content

Conversation

@koji
Copy link
Contributor

@koji koji commented Dec 31, 2025

Overview

update TypeScript version

close AUTH-2657

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

update TypeScript version

close AUTH-2657
@koji
Copy link
Contributor Author

koji commented Dec 31, 2025

  • solve @typescript-eslint/typescript-estree

@codecov
Copy link

codecov bot commented Dec 31, 2025

Codecov Report

❌ Patch coverage is 77.77778% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.85%. Comparing base (d403380) to head (7b533bd).

Files with missing lines Patch % Lines
step-generation/src/utils/liquidUtils.ts 0.00% 5 Missing ⚠️
...mmands/transformations/getSlotLabwareDefinition.ts 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #20464      +/-   ##
==========================================
- Coverage   56.03%   55.85%   -0.18%     
==========================================
  Files        3674     3680       +6     
  Lines      310545   311645    +1100     
  Branches    45826    46688     +862     
==========================================
+ Hits       174019   174079      +60     
- Misses     136283   137323    +1040     
  Partials      243      243              
Flag Coverage Δ
app 46.07% <66.66%> (-0.03%) ⬇️
protocol-designer 19.54% <22.22%> (-0.01%) ⬇️
step-generation 5.74% <11.11%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app-shell/src/protocol-storage/index.ts 46.62% <100.00%> (ø)
...organisms/Desktop/ChooseProtocolSlideout/index.tsx 50.52% <100.00%> (+0.17%) ⬆️
...Desktop/ChooseRobotToRunProtocolSlideout/index.tsx 64.53% <100.00%> (+0.34%) ⬆️
...nisms/Desktop/SendProtocolToFlexSlideout/index.tsx 63.43% <100.00%> (+0.83%) ⬆️
app/src/organisms/ModuleCard/Collapsible.tsx 81.08% <100.00%> (ø)
protocol-designer/src/steplist/fieldLevel/index.ts 52.52% <100.00%> (+0.17%) ⬆️
protocol-designer/src/ui/steps/selectors.ts 76.13% <ø> (+0.19%) ⬆️
shared-data/js/helpers/index.ts 53.64% <100.00%> (+1.34%) ⬆️
...mmands/transformations/getSlotLabwareDefinition.ts 92.30% <50.00%> (-7.70%) ⬇️
step-generation/src/utils/liquidUtils.ts 31.62% <0.00%> (-1.12%) ⬇️

... and 170 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these changes to File and Buffer constructors and the changes to various null-coalescences representing bugs? some of these are in the happy path and if they didn't work presumably we would have noticed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants