Skip to content

Conversation

@koji
Copy link
Contributor

@koji koji commented Oct 14, 2025

Overview

Unify all primary buttons into a single component

[design]
https://www.figma.com/design/1ot18My22DALIcjdLl5LJh/Helix-Design-System?node-id=4811-3035&m=dev

close AUTH-2397

Test Plan and Hands on Testing

run make -C components dev
Helix -> atoms -> Button

Changelog

Review requests

Risk assessment

mid since this pr applies the new button component to existing primary buttons

@koji koji marked this pull request as ready for review October 14, 2025 13:58
@koji koji requested a review from a team as a code owner October 14, 2025 13:58
@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

❌ Patch coverage is 90.38462% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.66%. Comparing base (64eb70a) to head (45086af).

Files with missing lines Patch % Lines
components/src/atoms/buttons/Button.tsx 91.66% 3 Missing ⚠️
components/src/atoms/buttons/AltPrimaryButton.tsx 50.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #19788      +/-   ##
==========================================
- Coverage   56.74%   55.66%   -1.09%     
==========================================
  Files        3649     3648       -1     
  Lines      303781   310398    +6617     
  Branches    42726    42876     +150     
==========================================
+ Hits       172392   172770     +378     
- Misses     131175   137404    +6229     
- Partials      214      224      +10     
Flag Coverage Δ
app 46.45% <84.61%> (+<0.01%) ⬆️
protocol-designer 19.38% <90.38%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...omponents/src/atoms/buttons/AlertPrimaryButton.tsx 100.00% <100.00%> (ø)
components/src/atoms/buttons/PrimaryButton.tsx 100.00% <100.00%> (ø)
components/src/atoms/buttons/index.ts 100.00% <100.00%> (ø)
components/src/organisms/Toolbox/index.tsx 97.11% <ø> (-0.03%) ⬇️
components/src/atoms/buttons/AltPrimaryButton.tsx 50.00% <50.00%> (-43.75%) ⬇️
components/src/atoms/buttons/Button.tsx 91.66% <91.66%> (ø)

... and 827 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@koji koji marked this pull request as draft October 14, 2025 14:18
@koji
Copy link
Contributor Author

koji commented Oct 14, 2025

  • fix test errors
  • fix check-js/lint-js errors

@koji koji removed the request for review from smb2268 December 13, 2025 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants