Skip to content

Minor optimization for SSLObject.read call #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tarasko wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Minor optimization for SSLObject.read call #725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
854aa0f
Optimize SSLObject.read call
Jan 29, 2026
53a873f
Merge branch 'master' into minor_cleanup_in_ssl_protocol
tarasko Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions uvloop/sslproto.pxd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ cdef class SSLProtocol:
object _incoming_write
object _outgoing
object _outgoing_read
object _ssl_read_max_size_obj
char* _ssl_buffer
size_t _ssl_buffer_len
SSLProtocolState _state
Expand Down
5 changes: 3 additions & 2 deletions uvloop/sslproto.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,7 @@ cdef class SSLProtocol:
"""

def __cinit__(self, *args, **kwargs):
self._ssl_read_max_size_obj = SSL_READ_MAX_SIZE
self._ssl_buffer_len = SSL_READ_MAX_SIZE
self._ssl_buffer = <char*>PyMem_RawMalloc(self._ssl_buffer_len)
if not self._ssl_buffer:
Expand Down Expand Up @@ -596,7 +597,7 @@ cdef class SSLProtocol:
bint close_notify = False
try:
while True:
if not self._sslobj_read(SSL_READ_MAX_SIZE):
if not self._sslobj_read(self._ssl_read_max_size_obj):
close_notify = True
break
except ssl_SSLAgainErrors as exc:
Expand Down Expand Up @@ -785,7 +786,7 @@ cdef class SSLProtocol:

try:
while True:
chunk = self._sslobj_read(SSL_READ_MAX_SIZE)
chunk = self._sslobj_read(self._ssl_read_max_size_obj)
if not chunk:
break
if zero:
Expand Down