Remove unused extension metadata fields (Icon, Repository, DownloadCount) #131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: JusterZhu <11714536+JusterZhu@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor extension module by removing unnecessary metadata
Remove unused extension metadata fields (Icon, Repository, DownloadCount)
Jan 29, 2026
JusterZhu
approved these changes
Jan 29, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Removes unused extension metadata fields (Icon, Repository, DownloadCount) from the extension metadata schema and eliminates related manifest-generation logic and documentation/tests.
Changes:
- Removed
DownloadCountfromAvailableExtensionand removedIcon/RepositoryfromExtensionDescriptor. - Updated package manifest generation to no longer emit
iconandrepository. - Updated tests and README examples to reflect the leaner schema.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/c#/GeneralUpdate.Extension/README.md | Updates metadata examples to remove icon and repository. |
| src/c#/GeneralUpdate.Extension/PackageGeneration/ExtensionPackageGenerator.cs | Stops writing icon/repository fields into generated manifests. |
| src/c#/GeneralUpdate.Extension/Metadata/ExtensionDescriptor.cs | Removes Icon and Repository properties from the descriptor model. |
| src/c#/GeneralUpdate.Extension/Metadata/AvailableExtension.cs | Removes DownloadCount from the available extension model. |
| src/c#/ExtensionTest/Metadata/ExtensionDescriptorTests.cs | Removes tests covering Icon/Repository properties and related nullability assertions. |
| src/c#/ExtensionTest/Metadata/AvailableExtensionTests.cs | Removes tests covering DownloadCount. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes three extension metadata fields no longer needed by the system:
Icon,Repository, andDownloadCount.Changes
Metadata Models
AvailableExtension: RemovedDownloadCountpropertyExtensionDescriptor: RemovedIconandRepositoryproperties with theirJsonPropertyNameattributesPackage Generation
ExtensionPackageGenerator.GenerateManifestAsync(): Removed conditional manifest generation for icon and repository fieldsTests & Documentation
AvailableExtensionTestsandExtensionDescriptorTestsImpact
Extensions now use a leaner metadata schema. Manifest generation excludes the removed fields. Existing extensions with these fields will still deserialize correctly due to optional property handling.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.