Skip to content

fix: resolve facebook ads context readability (externalAdReply) #2397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
awanmh wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix: resolve facebook ads context readability (externalAdReply) #2397

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6827693
fix: resolve facebook ads context readability
awanmh Jan 28, 2026
c84626d
fix: add fallback path for externalAdReply as suggested by sourcery
awanmh Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions src/utils/getConversationMessage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const getTypeMessage = (msg: any) => {
conversation: msg?.message?.conversation,
extendedTextMessage: msg?.message?.extendedTextMessage?.text,
contactMessage: msg?.message?.contactMessage?.displayName,
locationMessage: msg?.message?.locationMessage?.degreesLatitude.toString(),
locationMessage: msg?.message?.locationMessage?.degreesLatitude?.toString(),
viewOnceMessageV2:
msg?.message?.viewOnceMessageV2?.message?.imageMessage?.url ||
msg?.message?.viewOnceMessageV2?.message?.videoMessage?.url ||
Expand Down Expand Up @@ -49,9 +49,18 @@ const getTypeMessage = (msg: any) => {
: ''
}`
: undefined,
externalAdReplyBody: msg?.contextInfo?.externalAdReply?.body
? `externalAdReplyBody|${msg.contextInfo.externalAdReply.body}`
: undefined,

// --- FIX FACEBOOK ADS START ---
externalAdReplyBody: msg?.message?.extendedTextMessage?.contextInfo?.externalAdReply?.body
? `externalAdReplyBody|${msg.message.extendedTextMessage.contextInfo.externalAdReply.body}`
: msg?.message?.extendedTextMessage?.contextInfo?.externalAdReply?.title
? `externalAdReplyBody|${msg.message.extendedTextMessage.contextInfo.externalAdReply.title}`
: msg?.contextInfo?.externalAdReply?.body
? `externalAdReplyBody|${msg.contextInfo.externalAdReply.body}`
: msg?.contextInfo?.externalAdReply?.title
? `externalAdReplyBody|${msg.contextInfo.externalAdReply.title}`
: undefined,
// --- FIX FACEBOOK ADS END ---
};

const messageType = Object.keys(types).find((key) => types[key] !== undefined) || 'unknown';
Expand All @@ -60,7 +69,9 @@ const getTypeMessage = (msg: any) => {
};

const getMessageContent = (types: any) => {
const typeKey = Object.keys(types).find((key) => key !== 'externalAdReplyBody' && types[key] !== undefined);
const typeKey = Object.keys(types).find(
(key) => key !== 'externalAdReplyBody' && key !== 'messageType' && types[key] !== undefined,
);

let result = typeKey ? types[typeKey] : undefined;

Expand All @@ -73,8 +84,6 @@ const getMessageContent = (types: any) => {

export const getConversationMessage = (msg: any) => {
const types = getTypeMessage(msg);

const messageContent = getMessageContent(types);

return messageContent;
};