Skip to content

Conversation

@Pretty548
Copy link

@Pretty548 Pretty548 commented Jan 30, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  1. Created a form to collect customer name, email, t-shirt colour, and size
  2. Added validation to ensure all fields are required
  3. Implemented name validation with defined input rules
  4. Validated email input using a standard email pattern
  5. Provided exactly three colour options and restricted selection to those options
  6. Ensured the form has no action attribute as required

Questions

How did you decide what makes a “valid” customer name, and what rules did you use to validate it?

@netlify
Copy link

netlify bot commented Jan 30, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 2008fe3
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/697ccd2ed6229c0008843b80
😎 Deploy Preview https://deploy-preview-1097--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

6 similar comments
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@Pretty548 Pretty548 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 30, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 30, 2026
@Pretty548 Pretty548 changed the title Cape Town | 26-ITP-Jan | Pretty Taruvinga | Sprint 1 | Form Controls Cape Town | 26-ITP-Jan | Pretty Taruvinga | Sprint 2 | Form Controls Jan 30, 2026
@Pretty548 Pretty548 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 30, 2026
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

Regarding your question:

How did you decide what makes a “valid” customer name, and what rules did you use to validate it?

I would probably reference the answers gathered from AI and Google search.
If there is a rule, then chances are we can use JavaScript to enforce the rule.

Comment on lines +42 to +48
<input
type="radio"
id="color-blue"
name="color"
value="blue"
/>
<label for="color-blue">Blue</label>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note:
We can also wrap the radio button inside the label element as:

<label><input type="radio" name="color" value="blue"> Blue</label>

This way, we don't have to introduce id and for attributes.

required
/><br><br>
<fieldset>
<legend>Choose a T-shirt Colour:</legend>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wordings used on lines 32 and 58 could be made more consistent.

May I suggest showing your code to an AI tool and ask it to check for consistency and possible improvements?
It can often help us catch errors, improve consistency, and reinforce best practices.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants