BIRMINGHAM | 26-ITP-JAN | MERVE REIS | Sprint 2 | PRODUCT FORM #1079
+59
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mervereis
added
the
Needs Review
takanocap
suggested changes
Jan 27, 2026
takanocap
left a comment
takanocap
left a comment
There was a problem hiding this comment.
Please check that you have saved the assignment and pushed to github. I am not sure I can see any solution in the file
takanocap
added
Reviewed
Author
|
@takanocap I've added the product form to the html file. you can check again now |
mervereis
added
the
Needs Review
takanocap
suggested changes
Jan 30, 2026
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Product Form</title> | ||
| <link rel="stylesheet" href="style.css" /> |
There was a problem hiding this comment.
well done for the good Job. You have also included accessibility thats very good. Please keep it up. However, your styles.css may be missing or using the wrong reference. Please check this
|
|
||
| <div> | ||
| <label for="email">E-mail</label> | ||
| <input type="email" name="E-mail" id="email" placeholder="name@example.com" required aria-required="true" /> |
There was a problem hiding this comment.
is it possible to use the minlength for additional validation for email?
takanocap
removed
the
Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Created a product pick form