Skip to content

Conversation

@grantriches-byte
Copy link

@grantriches-byte grantriches-byte commented Jan 24, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I have completed all steps of the Wireframe task.

@netlify
Copy link

netlify bot commented Jan 24, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit dff033c
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6974ef8560b1a800088b1616
😎 Deploy Preview https://deploy-preview-1049--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (🟢 up 5 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

6 similar comments
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@grantriches-byte grantriches-byte changed the title Sheffield | ITP | Grant Riches | Sprint 1 | Wireframe Sheffield | 26-ITP-JAN | Grant Riches | Sprint 1 | Wireframe Jan 24, 2026
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR does not have a "Needs Review" label, but I assume it is ready to be reviewed.

Here are my feedback:

  • According to https://validator.w3.org/, there are two warnings in your code. Can you address them?

  • In the wireframe image, the Read Me links have a border. Can you add a border to all three Read Me links?

  • Optional Change: If you are up to some more challenge, you can try laying out the Read Me links in articles 2 and 3 so that they align horizontally nicely regardless of the length of the articles.

Don't forget to add the "Needs review" label to this PR when you have made all the changes.

A branch in Git is like a separate workspace where you can make changes and try new ideas without affecting the main project.
Creating a branch allows you to make changes without affecting the original version.
</p>
<a href="https://www.w3schools.com/git/git_branch.asp?_gl=1*1pmlokl*_ga*NzI4ODc3OTYyLjE3NjkxMTc0MzI.*_ga_9YNMTB56NB*czE3NjkxMTc0MzEkbzEkZzEkdDE3NjkxMTc0MzIkajU5JGwwJGgw">Read more about Git branches</a>
Copy link
Contributor

@cjyuan cjyuan Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Part of the URL in the link on line 45 is probably not needed.

Can you use an AI tool to find out which part of the URL can be deleted to produce a cleaner URL?

--space: clamp(6px, 6px + 2vw, 15px);
--line: 1px solid;
--container: 1280px;
V/* Reset */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is a typo on line 1.

@cjyuan cjyuan added the Reviewed Volunteer to add when completing a review with trainee action still to take. label Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants