-
-
Notifications
You must be signed in to change notification settings - Fork 409
Sheffield | 26-ITP-JAN | Grant Riches | Sprint 1 | Wireframe #1049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Sheffield | 26-ITP-JAN | Grant Riches | Sprint 1 | Wireframe #1049
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
6 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
cjyuan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR does not have a "Needs Review" label, but I assume it is ready to be reviewed.
Here are my feedback:
-
According to https://validator.w3.org/, there are two warnings in your code. Can you address them?
-
In the wireframe image, the Read Me links have a border. Can you add a border to all three Read Me links?
-
Optional Change: If you are up to some more challenge, you can try laying out the Read Me links in articles 2 and 3 so that they align horizontally nicely regardless of the length of the articles.
Don't forget to add the "Needs review" label to this PR when you have made all the changes.
| A branch in Git is like a separate workspace where you can make changes and try new ideas without affecting the main project. | ||
| Creating a branch allows you to make changes without affecting the original version. | ||
| </p> | ||
| <a href="https://www.w3schools.com/git/git_branch.asp?_gl=1*1pmlokl*_ga*NzI4ODc3OTYyLjE3NjkxMTc0MzI.*_ga_9YNMTB56NB*czE3NjkxMTc0MzEkbzEkZzEkdDE3NjkxMTc0MzIkajU5JGwwJGgw">Read more about Git branches</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part of the URL in the link on line 45 is probably not needed.
Can you use an AI tool to find out which part of the URL can be deleted to produce a cleaner URL?
| --space: clamp(6px, 6px + 2vw, 15px); | ||
| --line: 1px solid; | ||
| --container: 1280px; | ||
| V/* Reset */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there is a typo on line 1.

Learners, PR Template
Self checklist
Changelist
I have completed all steps of the Wireframe task.