[PWGJE] gammaJetTreeProducer updated substructure tables #14700
+13
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjonasALICE
requested review from
alibuild,
maoyx,
mfasDa,
mhemmer-cern and
nzardosh
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had to make some changes to the structure of the substructure table. In this way, the table is exactly always filled at the same time as the jet table.
The former implementation caused some problems when running on hyperloop, giving error messages related to the detection of unbound columns during AO2D merging.
The current implementation is now simpler and consistent with how the charged jet table is filled