remove dead code

Author: rosecodym

pkg/detectors/falsepositives.go

@@ -2,7 +2,6 @@ package detectors
 
 import (
 	_ "embed"
-	"fmt"
 	"math"
 	"strings"
 	"unicode"
@@ -172,30 +171,3 @@ func FilterResultsWithEntropy(ctx context.Context, results []Result, entropy flo
 	}
 	return filteredResults
 }
-
-// FilterKnownFalsePositives filters out known false positives from the results.
-func FilterKnownFalsePositives(ctx context.Context, detector Detector, results []Result) []Result {
-	var filteredResults []Result
-
-	isFalsePositive := GetFalsePositiveCheck(detector)
-
-	for _, result := range results {
-		if len(result.Raw) == 0 {
-			ctx.Logger().Error(fmt.Errorf("empty raw"), "Skipping result: invalid")
-			continue
-		}
-
-		if result.Verified {
-			filteredResults = append(filteredResults, result)
-			continue
-		}
-
-		if isFp, reason := isFalsePositive(result); isFp {
-			ctx.Logger().V(4).Info("Skipping result: false positive", "result", string(result.Raw), "reason", reason)
-			continue
-		}
-		filteredResults = append(filteredResults, result)
-	}
-
-	return filteredResults
-}

pkg/detectors/falsepositives_test.go

@@ -1,72 +1,12 @@
 package detectors
 
 import (
-	"context"
 	_ "embed"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
-
-	logContext "github.com/trufflesecurity/trufflehog/v3/pkg/context"
-	"github.com/trufflesecurity/trufflehog/v3/pkg/pb/detectorspb"
 )
 
-type fakeDetector struct{}
-type customFalsePositiveChecker struct{ fakeDetector }
-
-func (d fakeDetector) FromData(ctx context.Context, verify bool, data []byte) ([]Result, error) {
-	return nil, nil
-}
-
-func (d fakeDetector) Keywords() []string {
-	return nil
-}
-
-func (d fakeDetector) Type() detectorspb.DetectorType {
-	return detectorspb.DetectorType(0)
-}
-
-func (f fakeDetector) Description() string { return "" }
-
-func (d customFalsePositiveChecker) IsFalsePositive(result Result) (bool, string) {
-	return IsKnownFalsePositive(string(result.Raw), map[FalsePositive]struct{}{"a specific magic string": {}}, false)
-}
-
-func TestFilterKnownFalsePositives_DefaultLogic(t *testing.T) {
-	results := []Result{
-		{Raw: []byte("00000")},  // "default" false positive list
-		{Raw: []byte("number")}, // from wordlist
-		// from uuid list
-		{Raw: []byte("00000000-0000-0000-0000-000000000000")},
-		{Raw: []byte("xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx")},
-		// real secrets
-		{Raw: []byte("hga8adshla3434g")},
-		{Raw: []byte("f795f7db-2dfe-4095-96f3-8f8370c735f9")},
-	}
-	expected := []Result{
-		{Raw: []byte("hga8adshla3434g")},
-		{Raw: []byte("f795f7db-2dfe-4095-96f3-8f8370c735f9")},
-	}
-	filtered := FilterKnownFalsePositives(logContext.Background(), fakeDetector{}, results)
-	assert.ElementsMatch(t, expected, filtered)
-}
-
-func TestFilterKnownFalsePositives_CustomLogic(t *testing.T) {
-	results := []Result{
-		{Raw: []byte("a specific magic string")}, // specific target
-		{Raw: []byte("00000")},                   // "default" false positive list
-		{Raw: []byte("number")},                  // from wordlist
-		{Raw: []byte("hga8adshla3434g")},         // real secret
-	}
-	expected := []Result{
-		{Raw: []byte("00000")},
-		{Raw: []byte("number")},
-		{Raw: []byte("hga8adshla3434g")},
-	}
-	filtered := FilterKnownFalsePositives(logContext.Background(), customFalsePositiveChecker{}, results)
-	assert.ElementsMatch(t, expected, filtered)
-}
-
 func TestIsFalsePositive(t *testing.T) {
 	type args struct {
 		match          string