Use styling from sugar-artwork

[chimosky]

A couple of the css styling used already exists in sugar-artwork, find and replace them with the one in sugar-artwork.

As an instance, sugar4.graphics.toolbarbox.ToolbarBox uses a hardcoded css style when a toolbarbox styling exists in sugar-artwork that's for both toolbar and toolbarbox.

I'm sure they're others.

I'm creating this as I don't plan to look into it, this is needed to avoid duplicate of Sugar styling, sugar-artwork exists to keep track of Sugar styling and should be used.

@MostlyKIGuess You can look if you have the time.

Note: This issue requires you have the sugar live build setup, so you can test your changes. It also depends on Sugar being ported and there's a WIP for that, which you can contribute to.

[Dakshsharma1108]

Problem

• CSS was hardcoded across multiple widgets, causing duplication and drift from sugar-artwork.
• Styling changes required editing Python, making theme updates brittle.

Solution

• Single stylesheet: src/sugar4/graphics/sugar-gtk4.css holds all widget styles.
• Theme loader: src/sugar4/graphics/theme.py loads sugar-artwork if present, otherwise falls back to the bundled CSS.
• Components only add classes (no inline CSS): toolbar buttons, toolbox/toolbarbox, menu items, radio tool buttons, palette menu, tray, alerts.
• Auto-init: src/sugar4/graphics/init.py initializes the theme loader when graphics is imported.

is this right ? @chimosky @MostlyKIGuess

[chimosky]

I've edited my opening comment to include the link to sugar-artwork, it's my fault for not doing so.

sugar-artwork is one of the core APIs of Sugar, so it's installed with Sugar and contains the icons and styling needed for widgets in Sugar.

Hope this helps you understand the problem, if it doesn't, feel free to ask more questions.

[Dakshsharma1108]

So , only removing hard-coded css is enough?@chimosky

[Dakshsharma1108]

And then replace them with sugar-artwork

[Dakshsharma1108]

like this ? @chimosky

[chimosky]

Yes, but without the comment, it's redundant.

Also look at the note in my opening comment, a PR for this might not be tested and merged soon but it'll be a start.

[Dakshsharma1108]

after removing these hardcorded css the try and exception are needed or not ? @chimosky

[chimosky]

Please use text in the future for code, not screenshots.

I figure the purpose of the function is to apply css, I don't see why the function would exist if we're not doing that anymore.

[Dakshsharma1108]

So removing this is good or not?

[chimosky]

From my last response, I was saying it should be removed.

[Dakshsharma1108]

Got it

[Dakshsharma1108]

# Force label text to black
self._label.add_css_class("force-black")
style.apply_css_to_widget(self._label, ".force-black { color: #000000; }")
i think this is also not exist in sugar-artwork

[MostlyKIGuess]

Daksh, this might be a big change and you will need to understand how artwork works, it's difficult to review every comment that you make, maybe try exploring something else if you aren't familiar with the codebase.