Are you sure you want to pass every env on plugin invocation?

[dionysius]

cni/pkg/invoke/args.go

Line 57 in d5c71ad

env := os.Environ()

While debugging an issue I had with our custom CNI plugin I just found out that libcni forwards every env variable of the program calling CNI.

While I could manage the programs env this leads me to the question whether this feature is really a good idea. Shouldn't libcni invoke plugins only with known CNI env variables?

In my case it was an env LOG_TARGET=stdout which made our custom CNI plugin to output debugging info to stdout and thus break the json output.